https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30266 Bug ID: 30266 Summary: Holds marked waiting with a holdingbranch that does not match can cause loss of pickup locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When a hold is waiting, but its holdingbranch does not match the expected location we don't handle this case for display or for inputs on the page. This can cause loss of data when other holds are adjusted as we resubmit all holds when updating. We should adjust the page to only update changed holds, but for now we should handle this case and ensure necessary inputs are always present, and handle the case we have seen. To recreate: 1 - Place two holds on a record for two different patrons, with different pickup locations 2 - Check in one item at expected branch to set waiting 3 - Then either: - Use batch modification or item editor to change the holding branch for the item - Sign in to a different branch and manually transfer the item back to it's home location 4 - View the holds for the record 5 - Note the 'Pickup library' column is blank for that hold 6 - Change pickup location for other hold and press 'Update holds' 7 - Note the waiting hold is still blank, and now second hold has no pickup location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.