https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #23)
Can you clarify the situation? What's missing to make it ready for a QA review? I like the idea but don't manage to see how far we are from something done.
I think this is done. But Martin's follow-up was an attempt to think of further enhancements. Particulary, as he passes the $patron object around, we could rely on some implicit caching to calculate the libraries_... stuff once, no matter how many times it will be used. As for the gaps situation, this patch only covers the 'singular' use case, so that's a different bug. I narrowed the implementation to what I needed for bug 29275, and am willing to work on the plural embeds once we agree on the implementation. I also think we shouldn't leave gaps. -- You are receiving this mail because: You are watching all bug changes.