https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28420 --- Comment #18 from David Cook <dcook@prosentient.com.au> --- (In reply to mark.jaroski from comment #17)
In any case, this is probably not the *right* way to do it. But it's fast, and probably does no real harm since whatever problems it has are the same as the ones with the google version.
Make sense?
Oh yes I understand that. Personally, I was always against the Google version ;). But I hadn't prioritized upstreaming my own OpenID Connect client (which itself isn't perfect either of course), so I couldn't complain too much. Personally, I'm not really keen to have a Google version and an Azure version. I rather just have 1 generic version. But I won't stand in the way of someone else signing off and QAing this enhancement. You might want to sign up to the koha-devel listserv if you haven't already https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel. That can be a good place to try to generate interest for patches. In the meantime, if you update your patch to do your database update as per https://wiki.koha-community.org/wiki/Database_updates your patch will have a better chance of making it through. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.