https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24157 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Alex Arnaud from comment #19)
I think the third commit "Add new method Acq::Invoice::Adjustement->fund" is not the right place here. Right ? I don't see any use of it and no old code removed.
Hi Alex, It is used in "Bug 24157: New permission - edit_invoices" [% adjustement.fund.budget_name | html %] (In reply to Alex Arnaud from comment #20)
Blocker:
I still see the "Merge selected invoices" button in invoices list if i don't have the "edit_invoices" permission. So i can select invoices, click on it, but i get an empty invoice form and merge is not done.
So IMO there is two options:
1) i can see the merge option and the merge should be done, 2) i can't see the merge option and the checkboxes if i don't have the "edit_invoices" permission.
Questioning: should we assume that merging is editing and deleting ?
I created a new merge_invoices permissions. (In reply to Daphne Hoolahan from comment #21)
Comment on attachment 100288 [details] [review] Bug 24157: (follow-up) Conditionally show controls to reopen and close invoice
Review of attachment 100288 [details] [review]: -----------------------------------------------------------------
Suggested extension of this to conditionally show controls to delete invoices too, so that the checkbox for deleting an invoice is not displayed when the user doesn't have the correct permissions.
Hi Daphne, I found a "Delete" link on the invoice detail page, but I did not find one on a view where a checkbox is visible. Can you detail a bit more please? -- You are receiving this mail because: You are watching all bug changes.