http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6328 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Signed Off --- Comment #37 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-21 16:24:42 UTC --- ian, back to "please QA". (In reply to comment #35)
members/setdebar.pl is only used in the link on moremember.tt, which unblocks the patron. The query executed merely sets 'debarred' to $status, for whatever status is input in the form. Previously, when debarred was an integer, this was 0. Now that debarred is a date, and there is a debarred comment, the values submitted to the form should be updated to reflect this, or the script itself should be changed to more thoroughly handle $status = 0.
OK, fixed in the "follow-up for 6238 uploaded just now
This patch also changes the output of IsMemberBlocked, from returning the number of days they patron is blocked to the date they're blocked until. This means that issuingimpossible{USERBLOCKEDREMAINING} in C4::Circulation::CanBookBeIssued is populated with a date instead of an integer, breaking the display circ/circulation.tt (<li>Patron has had overdue items and is blocked for [% USERBLOCKEDREMAINING %] day(s).</li>). A simple change to circ/circulation.tt to handle this date correctly would suffice. This would introduce string changes.
Haven't you missed the "follow-up to deal with QA comments" patch ?, because it removes this string that was useless here. At least, I can't find it anymore on my setup.
The new documentation in C4/Auth_with_ldap.pm is off by a couple spaces... the indentation is off by about a full tab's worth for debarredcomment.
OK, fixed
KohaTest/Members/DebarMember.pm does not pass a date in it's tests, likely making the tests fail (or return false success).
OK fixed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.