https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #17)
1. Small UI changes (not advertised)
Before: https://snipboard.io/cRdEWA.jpg After : https://snipboard.io/qep6rS.jpg
a) No more pagination (should be restored imo)
Pagination works, it just doesn't have pages.
b) Missing space between action buttons
Will take a look
c) Default sort order is not the name instead of the ID
Will take a look
d) Table is displayed even if empty
I don't think this is a problem. The only solution is to count them in the controller .pl before rendering the page. Would you agree with such approach?
e) Default number of entries was 10, not 20 (better as it)
Will fix, this is configurable.
2. "Search cities" in the header does not longer works.
I didn't look at that. Well spotted
3. Why the indentation changes in cities.json?
I think my editor did that when I intended to re-indent the portion I added. Is it a problem?
4. We reached a point where we don't have XSS issue in our templates, all variables are correctly escaped. With this adding more JS code we should continue to enforce the rule, all the variables must be correctly escaped.
You mean data that comes from the API????
5. How does it work with the column settings?
Take a look at bug 25287 and bug 25288. -- You are receiving this mail because: You are watching all bug changes.