https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29074 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) The changes make sense, but I wondered if it wouldn't be safer to change sub _set_default_expirationdate { my $self = shift; my $period = C4::Context->preference('DefaultHoldExpirationdatePeriod') || 0; my $timeunit = ? This would mean one change in one spot instead of changing 2. We could just "do onthing" if DefaultHoldExpirationdatePeriod is undefined/empty. 2) For the note I suggest a tiny rephrase: If <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=DefaultHoldExpirationdatePeriod">DefaultHoldExpirationdatePeriod</a> is left blank default expiration date is not set.</br> ..., the default expiration date is not set. ..., no default expiration date is set. -- You are receiving this mail because: You are watching all bug changes.