https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21681 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- With my QA hat on.. I'm less happy with this. 1) We should not use Koha::Account::Lines directly.. the intention is to use Koha::Account as an intermediary for dealing with all account actions. 2) If we do the above, there is a method directly from the Koha::Patron object you have in ILSDI already ($patron->account->*) 3) I don't really believe ILSDI should return ALL accountlines associated to a patron. In reality, the intention is for outstanding debits (and possibly outstanding credits) to be usable. However, that would be a change of the api, and so is probably out of scope. As such, we could add a 'lines' method to Koha::Account which would return all accountlines filtered by the user. -- You are receiving this mail because: You are watching all bug changes.