http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #24)
QA comment (and some discussion with joubu)
Anyone who can set systempreferences can completely break Koha anyway. So I don't think it's a necessity to add some sanity check. The way the follow-up patch is made look quite ugly to me, it would be better to check if we've only letters, numbers, - and _ as column names.
And, imo, we don't need any check at all in fact. Marcel, your opinion on that ?
We will not improve quality by skipping checks :-) Let's not make it worse (sounds like a commercial..). I agree that the followup does look somewhat "ugly". Adding quotes and removing them again.. A check on valid column names would be nice, but I understand that it could be a little over the top for this routine. In conclusion: If you still have a good idea, please submit. Or remove the current quote thing.. -- You are receiving this mail because: You are watching all bug changes.