https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overlaying with Patron |Cannot overlay patrons when |Imports cannot be done if |matching by cardnumber if |user id and cardnumber are |userid exists in file and |the same. |in Koha Version|18.05 |master CC| |nick@bywatersolutions.com --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- This appears to have been intentional according to tests, but I think the tests and assumption were wrong. Essentially if not matching by userid and a userid is inthe file we try to create a new user and see if the user id is valid. It isn't, of course, because the patron exists. has_valid_userid is supposed to ignore a duplicate for the existing borrower, but we avoid that check by creating a new borrower!?!? Patch coming -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.