https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20956 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #35 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #29)
I have not followed the last changes in this area (logging), but I don't think you should take care of the changes in C4/Logs.pm
Well, I do think we should centralize it, but not without discussion and advertising.
For instance, here is the call from Koha::Patron->store to_json( $info, { utf8 => 1, pretty => 1, canonical => 1 } )
It's bad (to_json is slower), but it uses pretty and canonical, what you don't.
As lisette referenced, this topic was discussed and approved via bug 25159 and the corresponding ACTN1 coding guideline which was approved at a developers meeting. A good next step would be to centralize permissions changes within Koha::Patron but I think that is out of scope for this bug ( but would be a great next step ). -- You are receiving this mail because: You are watching all bug changes.