https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #14)
% git fetch origin % git reset --hard origin/master % git clean -f -d % prove t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Letters/TemplateToolkit.t .. ok All tests successful. Files=1, Tests=13, 4 wallclock secs ( 0.06 usr 0.00 sys + 2.78 cusr 0.10 csys = 2.94 CPU) Result: PASS
What I meant is that the test 'Hold object used correctly' successes when we are expecting it to fail.
Are you applying the "Bug 16942 [QA Followup] - Add unit test" patch to master before running the tests? If you apply that patch, the test should fail. Then, if you apply "Bug 16942 - Confirm hold results in ugly error" the test should pass.
I completely understood that. So maybe you should explain me why the following test pass: 180 $prepared_letter = GetPreparedLetter( 181 ( 182 module => 'test', 183 letter_code => 'TEST_HOLD', 184 tables => { 185 reserves => [ $patron->{borrowernumber}, $biblio->id() ] 186 }, 187 ) 188 ); 189 is( $prepared_letter->{content}, $hold->id(), 'Hold object used correctly' ) What does reserves => { $borrowernumber, $biblionumber } mean? How do you know that $borrowernumber is a borrowernumber? It looks like something magic and to me it should not work. -- You are receiving this mail because: You are watching all bug changes.