http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006 --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> --- (In reply to Larry Baerveldt from comment #9)
Like Kyle, I am concerned about regression. The issue addressed by Bug 13432 was a very serious one for us, and affected virtually every site using SIP. New child processes were continually being created throughout the day, and older child processes were never dying. In some cases the number of SIP processes would literally max out the RAM. We had to introduce daily restarts of SIP in our crons, and for some sites, even that was not enough. And Bug 13432 DID fix that problem.
As to the problem of the timeout logic causing dropped connections post 13432, we simply fixed that on our servers by increasing the timeout in the Service and Institution levels to 360. That worked for most SIP vendors.
That said, I think this patch would be okay if it includes Kyle's suggestion to have the client_timeout default to the timeout if not defined.
If you apply the change in bug 15418 do you still see this problem? In Pre-Fork child processes should not die - but my suspicion is that due to the rather awkward way the callback was originally implemented they are not always left in a state ready to be reused. In part to deal with those problems I started using Fork in production and it seems more reliable -- You are receiving this mail because: You are watching all bug changes.