https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109772|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109992&action=edit Bug 26242: Move translatable strings out of results.tt and into results.js This patch removes the definition of translatable strings out of templates and into the corresponding JavaScript file, using the new JS i81n function. To test: - Apply the patch and perform a catalog search which will return multiple results. - Without checking any checkboxes, click the "Add to Cart" button. You should see a message, "No item was selected." - The same should happen if you select an item from the "Add to list" menu or click the "Place hold" button. - Click the "Select all" link to check all checkboxes. - Click the "Place hold" button. - You will inevitably get a "One or more selected items cannot be placed on hold." message. If you were to want to complete this process you would have to painstakingly sift through each search result to find which item couldn't be placed on hold so that you could uncheck the corresponding checkbox. Luckily this test plan doesn't require you to do that. - If you don't get an error message you're living in a catalog utopia unlike any I have ever seen. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/pages/results.js for translation, e.g.: msgid "Nothing is selected" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: Alexis Ripetti <alexis.ripetti@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.