https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16909 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53345|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 53350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53350&action=edit Bug 16909: Koha::Patrons - Remove checkuniquemember C4::Members::checkuniquemember was not really nicely written, was only used once and was not covered by tests. I think it does not make sense to keep such complexity and have this code in the subroutine/method. Looking at this patch it seems that what this subroutine did can be done easily in the pl script in few lines. Test plan: 1/ Create 2 organisations with the same "surname": you should get a warning. 2/ Create 2 patrons (non-organisation) with the same surname/firstname/date of birth, you should get a warning Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.