https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18996 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
From that bug:
If I check in an item where the issue id is already in old issues (I inserted this id for testing purposes), AddReturn correctly gives me back me a zero status and DataCorrupted message. However, SIP somehow ignores it. It returns a 10 with ok=1 while it should return a 10 with ok=0. The problem is in ILS.pm line 219 $circ->ok( ( $checked_in_ok && $item ) || ( $item && $item->{patron} ) ); In this specific case $circ->ok was already set to false in do_checkin just before that line. But now this line sets ok back to true. I guess this is a more fundamental problem. Because if AddReturn did set the ok flag to false for another reason, the same could happen. So I would propose to solve it on another report. I am not fully sure if we can just test if $circ->ok is still true before running this line 219, and leave it false when it is false. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.