https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #29)
Generally looks good. But still some things:
Patch 4 seems to be just for debugging purposes (Data::Printer). The search is saved in account_lines but it is not used any more?
Sounds like I have messed my patches when I squashed them. I removed it.
Patch 6 adds locking. You lock the message queue. But you should lock old issues, I guess.
Outch :-/
Furthermore, how long do you really need the lock? Your lock now extends to the very end of MarkIssueReturned, but isn't the lock actually needed only when calculating max+1 and storing it in old issues ?
Yes agreed. -- You are receiving this mail because: You are watching all bug changes.