http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #46)
I've spent a bit of time with the current patch series, and I've *not* been able to reproduce the problem where going to members/member.pl induced DataTables to try loading the entire patron database.
Thanks for testing Galen!
To avoid that, a LIMIT clause should *always* be added to the patron query, with sensible default values if iDisplayStart and/or iDisplayLength are not supplied. 0 and 20, respectively, I'd say.
We may also want to consider hardcoding an absolute cap (say 100?) on iDisplayLength.
Will be fixed, using 20 by default (like the DT default value). (In reply to Galen Charlton from comment #48)
As a final comment, for the moment, I think it is best if merely going to the patron home page does not do a search -- retrieving 20 records isn't a huge performance hit, of course, but the first 20 records are very unlikely to be useful. It would be better to omit the search so that the search form can be rendered more quickly.
This should be distinguished (by checking for POST vs. GET, presumably) from the case where the staff user intentionally does a blank patron search as a way of bringing up a list of all patrons.
Will be fixed too, the table will be hidden by default. (In reply to Galen Charlton from comment #49)
I lied, one more comment: there is a minor but annoying change of behavior.
Prior to the patch, if you start from the patron home page and do a search that retrieves a single hit, it automatically redirects to the details page for that patron. You can then use the back button to get back to the patrons home page.
After the patch, the back button is effectively broken -- you can go back, but it will then immediately re-run the search and redirect you back to the patron record.
It would be *really* nice if it didn't do that.
It was a feature :) The goal was to display the same results using the back button. The former request already lead to the disappearance of this feature (with the side-effect too). -- You are receiving this mail because: You are watching all bug changes.