http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
From code review:
1) (normal) The descriptions for edit_items_restricted and items_bachmod_restricted are now no longer correct, since the preferences have been added to avoid hardcoding MARC fields - maybe refer to the prefs instead? 2) (non blocker) Patch keeps(?) a CGI::scrolling_list instance - could be in conflict with one of Bernardo's patches there: additem.pl: $subfield_data{marc_value} =CGI::scrolling_list(@scrparam); 3) (non blocker) Database updates could be merged. 3) Suggestion: should we squash the patches (maybe 1-9 + )? Because the permissions got renamed and some other things that could avoid some confusion. Also an updated summary of the changes and a test plan would be great. -- You are receiving this mail because: You are watching all bug changes.