https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31106 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 137185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137185 Bug 31106: Fix links generated in XSLTs Review of attachment 137185: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=31106&attachment=137185) ----------------------------------------------------------------- Bit of a deeper review this time for master... ::: koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl @@ +578,4 @@
</xsl:if> </xsl:template>
+ <xsl:template name="fix_query_term">
Maybe we could call this 'quote_term' or something.. 'fix' feels a bit unspecific? We're doing two things here actually.. we're escaping quotes and URI escaping.. then we leave the overall quoting of the whole string to the caller.. Maybe 'escape_phrase' or 'escape_term' then? @@ +586,5 @@
+ <xsl:value-of select="$term"/> + </xsl:with-param> + </xsl:call-template> + </xsl:variable> + <xsl:value-of select="str:encode-uri(translate($fixed_term, '()', ''), true())"/>
I'm a bit confused by the translate.. we're translating '()' here, but we were translating '/' in some places instead before this patch.. can you explain your choice? @@ +589,5 @@
+ </xsl:variable> + <xsl:value-of select="str:encode-uri(translate($fixed_term, '()', ''), true())"/> + </xsl:template> + + <xsl:template name="escape_quotes">
Excellent, you renamed it here to 'escape_quotes' as opposed to 'remove_quotes' :) -- You are receiving this mail because: You are watching all bug changes.