https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Bug ID: 32496 Summary: Reduce unnecessary unblessings of objects in Circulation.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org There are a lot of instances in of unnecessary unblesssings in Circulation.pm (and also in some other parts of the C4 namespace), for legacy reasons I assume as it was an convenient way not having to adept the code to much after changing to the object oriented interface. This patch builds on Bug 31735 and cleans up a large part, but not all, of these uncalled-for unblessings. I focused mainly on refactoring CanBookBeRenewed and the subroutines it calls as this is run for each checked out item and has on of the highest performance impacts of the circulation related subroutines. The performance gains are pretty modest though, so the main motivation is to clean up the code (and in some instances avoid having to re-fetch the object where a method needs to be called, and an unblessed hashref was passed in). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.