http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30604|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30620&action=edit BUG8446, Follow up: Refactor to clean up bad practice - A number of issues were highlighted whilst writing sensible unit tests for this module. - Removed unnessesary call to context->new(); - Global variables are BAD! - Croaking is a wimps way out, we should handle errors early and properly. -- You are receiving this mail because: You are watching all bug changes.