https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27066 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #7)
Please document on https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks
Looking at the code and comparing with the similar after_item_action hooks I wonder about the placement in the code.
The implementation on bug 22709 adds the hooks before the logs are written, this adds them after.
I could imagine that plugins could actually change the data, so would result in a different logging result. So I think "before" would be better. What do you think?
I agree we must have same behavior. But I see _after_item_action_hooks is at the very end of store() : https://git.koha-community.org/Koha-community/Koha/src/commit/4f96b6767a1be0... After action logs and search engine indexing. Note that a main difference is that patron store() is in a DB transaction. -- You are receiving this mail because: You are watching all bug changes.