https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26118 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110755|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110784&action=edit Bug 26118: Move translatable strings out of tags/review.tt and into tags-review.js This patch removes the section of the tags review template which defined strings for translation. They can now be embedded in the JavaScript file, wrapped in the __() function. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Tags and perform some actions which will trigger the use of translated strings in the interface. For instance: - Approving and rejecting tags - Testing tags which are approved, rejected, or unclassified. - Status messages for these operations should work correctly. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/pages/tags-review.js for translation, e.g.: msgid "Both subfield values should be filled or empty." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.