https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 58809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58809&action=edit Bug 17501: [Follow-up] QA Requests This patch makes the following changes, as requested by QA: [1] UploadedFile->delete always calls SUPER::delete. The return value normally comes from SUPER::delete; if removing the file failed, we return false. Two warns are kept. Since delete does no longer return the filename, a few changes were needed in tools/upload.pl. [2] Method getCategories is moved to UploadedFiles. Script tools/upload.pl now only contains one call. Added a use C4::Koha. [3] Calls UploadedFiles->delete as class method. As a result I removed method delete_errors for now; may be reconsidered on a new report. [4] Adjusted three ->search calls for id and public to ->find calls. [5] If you pass no id to upload.pl when deleting, you don't get an alert. All by all, we got rid of 15 lines ! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.