http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #13)
Hi Jared,
For discussion:
This patch is interesting. It introduces some new notions into Koha. For example, objects appear into Koha with an (not one of the least) Authority module \o/ But ... :)
Why do you choose an old method to do OOP in Perl (bless, SUPER) ? I think you may have heard about Moose or Moo, why don't use one of them directly from the beginning of the Koha::* rewriting?
My experience with Moose and CGI is that it's kind of slow. This seems like a huge problem on something as core as authority and bibliographic record objects. Also, after I tried to get the solr code working on my system Moose no longer functions. Choosing between core functionality (with a version of Moose that installs) and Solr (with a complex install procedure that will presumably leave Moose not working elsewhere) seems like a bad choice.
It seems your naming into the Koha namespace is not in agreement with the wiki page: http://wiki.koha-community.org/wiki/Koha_Namespace_RFC
It's easy to do a follow up to change the name. If you tell me what you'd like it called, I will do a follow-up that changes the name. I think it should probably be Koha::DataObject::Authority, based on the RFC, but I decided to just call it "Koha::Authority" until I had a second opinion.
For new files, I think a best practice is to use "use Modern::Perl" instead of "use strict; use warnings;" But nothing is written on the wiki. You are free to keep these lines.
I'm not attached to them. :)
I really like your system of plugin. Our BibLibre dev/solr branch already have this kind of plugin for the routine index_record. This system is used for 1 index (for example we have a lot of plugins: Date (for index containing dates), Callnumber, isbn (for a dash management), etc.). Here we want to add a processing in 1 case (but other cases will certainly come). We can imagine to add a new part in the searchengine configuration page containing a list of features like this one. Thus, the routine will grow quickly and make it unmaintanable. In fact, we would have a pluggable system here too. But it is not for now...
I wrote this with the idea that we should be able to use this filter system elsewhere in Koha, too... as a place to put the filters from dev/solr, as well as (conceivably) before display. This of course makes speed even more crucial. -- You are receiving this mail because: You are watching all bug changes.