https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38136 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this, starting with a test plan and my first findings: == TEST PLAN == Before applying the patch: * Install at least one additional language. In ktd: sudo koha-translate --install de-DE --dev kohadev * Make sure the language is activated in the system preferences: - OpacLanguages - StaffInterfaceLanguages * Go to administration > itemtypes * Translate one or more of the item into the installed language by - Edit itemtype X - Clicking on the "Translate into other languages" link * Verify in several places, that the item type description is shown as expected: The description should show translated when switching between translations - Staff interface detail page (API): see bug 40666 - Staff interface search results - facets - items in right column - Staff interface advances search After applying patch: * Run updatedatabase * Update translated templates. in ktd: sudo koha-translate --update de-DE --dev kohadev * Restart all the things: restart_all * Repeat verify that the correct itemtype descriptions are shown everywhere - You can use the suggestions above and check some more beyond that. == FINDINGS == 1) No way back to item type (suggestion) Translating item types no longer opens in a modal, which is fine for me, but there is a small usability issue: There is no way to return to the item type you have been editing outside of the the link in the breadcrumbs. As Save and Cancel buttons make no sense here, we might want to provide a link back to the item type edit page instead. 2) Testing functionality (blocker) * Verify in several places, that the item type description is shown as expected - OK Staff interface detail page (API): worked nicely now - OK Staff interface search results - NOT OK facets - OK items in right column - OK Staff interface advanced search - OK Edit item form - OK pull down for item types - OK item type table on top of the page - OPAC search results - NOT OK facets - OK OPAC detail page I found that the facet translations don't work already with Elastic on 24.11/main, so I filed it separately: Bug 42187 - Elasticsearch: Item type translations broken for facet descriptions Some notes: - This rewrites /svc/localization: I feel we will probably want to remove that in a later patch, but since this has been sitting for quite a while, it will be better suited for a separate bug. -- You are receiving this mail because: You are watching all bug changes.