https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33668 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #19 from Andreas Roussos <a.roussos@dataly.gr> --- (In reply to Roman Dolny from comment #18)
(In reply to Andreas Roussos from comment #17)
... This patch adjusts the JavaScript logic so that when the page first loads and the search <input> is empty, the 'Clear search' button will not be displayed at all.
The 'X' (Clear search) button will only appear once the user has typed something in the search <input> area. ... Test plan:
1) Apply the patch. 2) Do a hard refresh (CTRL+F5) on the OPAC main page to reload all JS assets. 3) Notice that the 'Clear search' button is not displayed. 4) Try to search for something -> the button appears! 5) Use the 'X' button to clear your search -> the search terms are cleared and the 'X' button hides itself!
I can't confirm p. 4. Button appears only when typeing but is not displayed after performing search (at screen with search results). It again appears when click in search box, but it is one more click to show button and clear.
I also tested patch without last commit - works as described. Thank you for testing this, Roman -- you're absolutely right!
I will amend my patch and adjust the test plan to account for what you discovered. -- You are receiving this mail because: You are watching all bug changes.