https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063 --- Comment #69 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Marcel de Rooy from comment #68)
Still working on this one now. Preliminary results:
sub CancelExpiredReserves { + return unless C4::Context->preference("ExpireReservesMaxPickUpDelay"); This may have a unwanted side-effect. If we do not use the pickup delay, but still want to cancel expired reserves.
You mean: If ExpireReservesMaxPickUpDelay is set to don't allow ? If yes, this is because we don't want to cancel expired reserves right ? Or i don't understand the syspref.
sub set_waiting { [...] + if ( C4::Context->preference("ExcludeHolidaysFromMaxPickUpDelay") ) { + $expirationdate = $calendar->days_forward( dt_from_string($self->waitingdate), $max_pickup_delay ); + } This may cause something weird. If you do a second
Is it possible that the code of set_waiting (after tranferToDo) should be called 2 times for the same reserve ? -- You are receiving this mail because: You are watching all bug changes.