https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Rebuilt rather than rebased: a straight rebase of the 2019 patch isn't possible any more (Koha::Borrower, sample_notices.sql and the news block have all moved on), and it turns out no Perl is needed any more. Going through the earlier comments: - The reason it failed in 2019 (comments 19/20): the notice used 'patron' where the template variable is 'borrower'. The new notice uses 'borrower' for the patron and loops over 'checkouts', which is what C4::Members::IssueSlip already passes to quick slips as the 'issues' loop. Because of that, the new Koha::Patron->todays_checkouts method from the old patch isn't needed and has been dropped (comment 6 asked for tests for it). - The test plan said ISSUESLIP rather than ISSUEQSLIP (comments 16/17): corrected. - Localised sample_notices.sql files (comment 4): the only sample notices file left is the English sample_notices.yml, so only that is touched. - Due dates are shown with the time, as the historical <<issues.date_due>> did, and user-entered fields are html-escaped. New test in t/db_dependent/Members/IssueSlip.t: it renders the ISSUEQSLIP that ships in sample_notices.yml for a patron with a checkout from today (and one from yesterday that must not appear) and checks the library, patron name, card number, date, title, barcode and due date. Against the old notice only the 'no historical syntax' check fails, i.e. the rendered slip is the same as before. I also printed the slip through members/printslip.pl?print=issueqslip in KTD and it shows all of the above. koha-qa passes. Not included: comment 9 asked for is_from_today on Koha::Checkout independently of this bug; nothing here needs it, so I've left it for its own bug. The Rescued-by / Signed-off-by lines from the old attachment are kept on the commit. Setting the status to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.