http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10663 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20155|0 |1 is obsolete| | Attachment #20156|0 |1 is obsolete| | --- Comment #28 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 20362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20362&action=edit Bug 10663 - Revert and use CheckReserves for CanBookBeRenewed It makes renewal lock by holds work again. Unit tests as follow up Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This reverts changes made to CanBookBeRenewed by patches from bug 9376. GetReserveStatus is not suitable to recognize if an item can fild a hold on return and CheckReserves is restored. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Bug 10663: Follow-up - Revert and use CheckReserves for CanBookBeRenewed CheckReserves returns '' when no reserve is found, so $resfound will always be defined and we need to check if it's true. This is part of the revert. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Squashed the above two patches. Works as advertised. -- You are receiving this mail because: You are watching all bug changes.