https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42383 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 209568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209568&action=edit Bug 42383: (follow-up) Show patron notification info in hold and recall modals The legacy returns page shows how the patron will be notified in the hold and recall confirmation dialogs. Consume the notification_summary embed (Bug 43486) to render the same detail: - "Patron notification: Email, SMS." (or "Patron is not notified.") - "Main contact method: ..." The hold modal uses the Hold_Filled transports; the recall modal uses the Recall_Waiting transports (the notice that fires when a recall is set waiting on checkin). The boxes are styled like the legacy page. This wires hold.patron.notification_summary and recall.patron.notification_summary into the checkin embed (client and swagger enum) and renders the lines in ConfirmationModal. Test plan: 1. Have a patron with a Hold_Filled and/or Recall_Waiting messaging preference set, and place a hold/recall 2. Check the item in, yarn build => SUCCESS: the confirmation modal shows the patron notification line and the main contact method, matching the legacy returns page 3. Try a patron with no messaging preference => SUCCESS: the modal shows "Patron is not notified." in a grey box 4. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.