https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #98 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches rebased, conflicts in notices sql files fixed! QA comments: 1/ FAIL Koha/Printer.pm FAIL critic "$pdf_data" is declared but not used at line 61, column 9. Unused variables clutter code and make it harder to read. 2/ What's the status of the NET::Printer lib? It's not packaged already. Kyle, did you try to package it? Failing QA for 1. -- You are receiving this mail because: You are watching all bug changes.