https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26459 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #3)
It works and QA tools are happy :)
1. It seems these two lines of code do the same thing: default to + if not - passed
hold_mode => $hold_mode eq '-' ? '-' : '+', my $hold_mode = $params->{hold_mode} || '+';
OK, removed
2. IIUC we are using a separated flag as opposed to having something like "-m hold+"/"-m hold" and "-m hold-" (not sure if that would be more clear to use) because that reflects better the underlying SIP protocol. (direct mapping to the flag) A bit verbose the separate flag but that should make sense.
I can rebuild if there is strong preference, I just wanted a quikc way to do this
3. Accepts +: Add hold or -: Cancel hold, defaults to + Is ↓that↓ more clear? Accepts "+" to add hold or "-" to cancel hold, defaults to +
Yes, updated
4. Not really related thing, shouldn't the following place an item level hold?
sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --patron 23529001000463 --item 39999000000511 -m hold -l CPL
It places a record level one. (which can be piled up and bypasses Holds per record circ rule)
See bug 26461 -- You are receiving this mail because: You are watching all bug changes.