http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Failed QA --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-18 16:26:07 UTC --- My 2 cents :
I would think it would be more consistent to use <<YY>> and <<USER>> tokens, instead of raw strings. This would reduce the likelihood of substitution mistakes dramatically, and be consistent with the tokens we use in Notices.
==> I fully agree with Ian.
Also, I'm not positive that we should be governing individual subfield logic directly in the main code;
==> partially agreeing, but Ruth patch fixes a bug, it's not an improvement, so it should be in another bug QA comment: * what will be the behaviour for existing setups ? I feel they'll see their working user not working anymore (as we need USER) . It's worth a small updatedatabase with something like "UPDATE marc_subfield_structure SET defaultvalue='USER' WHERE defaultvalue='user'" Marking failed QA for now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.