https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #102 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Jonathan Thanks for that. I've rebased as I was getting conflicts on a couple of commits.
acqui/addorder.pl is logging a MODIFY_BASKET, is that expected?
I believe so. addorder processes the submission from the "New order" form when adding an order to a basket, so logging the basket modification makes sense here I think.
Why are you adding borrowernumber?
That was a hangover from when ModBasket was explicitly logging the borrower. This was highlighted as unnecessary duplication, so I removed it from the logging in the patch titled "Bug 23971: (follow-up) Remove data duplication", but missed removing it from the ModBasket call. I've now created a new commit that removes it, thanks for highlighting it. -- You are receiving this mail because: You are watching all bug changes.