https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31642 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Pedro Amorim from comment #20)
From my understanding, custom HTML customization locations are meant to only be used by plugins (e.g. core is not querying or using'em). If this is the case, isolating this possible issue only to installations that use said plugins would be better than not handling it at all. 'is_system' AV entries should, at the very least, not be deletable through the UI, imo. Additionally, plugin code making use of 'custom' locations should know that, because they're 'custom', they may or may not exist, so can error handle accordingly. Whereas core Koha using 'is_system' should ideally never need to handle the case of them not existing.
Agreed. Will still try if I can get a first start on av.is_system on this report while postponing more changes to a separate one.
True, but we should at least consider displaying "!" with some text like "current value doesn't match any of the options" or similar. I know this patchset doesn't introduce this pattern in Koha, but it's adding yet another possibility where it may happen.
Will try. Not sure if people will oppose that as a "new inconsistent pattern". But maybe an alert on the page could do as well? Coming back later.
I don't know. I don't feel comfortable PQAing it as is because it adds the possibility for staff members to create problems for themselves in a place that they couldn't before, but I also understand it's a deeper/wider problem not exclusive to this patchset.
A possible alternative here would be to add a filter hook to get_html_customizations_options added in bug 39900. Needs some changes but would allow for plugins to hook into the list of available customization locations and add whatever they want. Though personally I think the 'is_system' approach for AV values would benefit Koha more as a whole.
Looking at the is_system approach. -- You are receiving this mail because: You are watching all bug changes.