https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35117 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 211457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211457&action=edit Bug 35117: (QA follow-up) Search by title when there is no 001 to link on With UseControlNumber enabled, get_components_query and get_volumes_query only built a search when the record has a 001. get_components_query then went on to search for an undefined value, which warns: Use of uninitialized value in concatenation (.) or string at Koha/SearchEngine/Elasticsearch/QueryBuilder.pm while get_volumes_query returned nothing at all. Test for the 001 first, so that a record without one is searched for by title, as it is when UseControlNumber is disabled. Both methods now do the same. The previous patch added the bib-level limit to the title search of get_components_query without updating the test that checks it, so do that too, and add tests for a record without a 001 and for flavours other than MARC21. To test: 1. prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! 2. Enable UseControlNumber and find a record that is a host item (analytics) whose record has no 001 => It shows its component parts, found by title, and there is no warning in the logs 3. Sign off -- You are receiving this mail because: You are watching all bug changes.