http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 22784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22784 Bug 11126 - Make the holds system optionally give precedence to local holds Review of attachment 22784: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11126&attachment=22784) ----------------------------------------------------------------- Ok, starting with a code review :) Looks good so far: - system preferences are added correctly - new feature is off by default - unit tests are provided Only one small issue with one of the comments: ::: C4/Reserves.pm @@ +915,5 @@
return ( "Waiting", $res, \@reserves ); # Found it } else { + # Lazy fetch for borrower and item. We only need to know about the patron and item + # each and every time if we are using LocalHoldsPriority. This is a great place to + # leverage the inherent lazy fetching of DBIx::Class.
I think DBIx::Class is currently not yet used here, so the comment could be fixed in a follow up. -- You are receiving this mail because: You are watching all bug changes.