http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12086 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 27428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27428 [SIGNED-OFF] Bug 12086 - Hold priorities incorrect, when waiting status was reversed Review of attachment 27428: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12086&attachment=27428) ----------------------------------------------------------------- Why don't you use t/db_dependent/Holds.t? ::: t/db_dependent/Holds_12086.t @@ +1,2 @@
+#!/usr/bin/perl +
Are you sure we want 1 file per bug? This is a new way to do. Maybe should you sent an email to the list to get other opinions. @@ +15,5 @@
+ +BEGIN { + use FindBin; + use lib $FindBin::Bin; +}
Why do you use FindBin? @@ +40,5 @@
+my ($bibnum, $title, $bibitemnum) = create_helper_biblio(); + +# Helper item for that biblio. +diag("Creating item instance for testing."); +my $item_barcode = '99999999999999999999';
Hum, yes but why not "my_barcode"? :) @@ +48,5 @@
+my @borrowernumbers; +foreach (1..$borrowers_count) { + my $borrowernumber = AddMember( + firstname => 'my firstname', + surname => 'my surname ' . $_,
Please don't use the variable loop $_ to avoid futures errors. -- You are receiving this mail because: You are watching all bug changes.