https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25078 --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Julian Maurice from comment #50)
Comment on attachment 121909 [details] [review] Bug 25078: Put db revs into different files to handle them better
Review of attachment 121909 [details] [review]: -----------------------------------------------------------------
::: installer/data/mysql/db_revs/skeleton.pl @@ +3,5 @@
+{ + bug_number => "BUG_NUMBER", + description => "A single line description", + # description => ["Multi", "lines", "description"], + # description => sub { return ["Your dynamic description"] },
I think there is something wrong about multi-lines/dynamic description. Why do we need that ? I think that we are confusing the update's "description" (what the update is supposed to do) with the update's "report" (what the update has done).
How that? I don't understand. We have several examples in the past where we have several lines. Basically a DBrev can contain several things. To prevent long line we split it and display 1 action per bullet point.
A dynamic description also implies that it should be generated after the update is done, because the 'description' sub might use some data from the 'up' sub, but what if we want to display a list of pending updates before executing them ?
It's not what is done (and has never been done). We display display the output when the DBrev has been executed. Are you suggesting you should change this behaviour? -- You are receiving this mail because: You are watching all bug changes.