https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129608|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 131861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131861&action=edit Bug 29486: _koha_marc_update_bib_ids no longer needed for GetMarcBiblio This subroutine is ensuring that the biblionumber and biblioitemnumber will be part of the MARC record. We should not need that, unless there is something broken somewhere else. This line has been added by the following commit: commit 4e95e94727b09b33d2f6c597bdd218a59dcc3681 Bug 6789: biblios with many items can result in broken search results link """ To this end, it also moves the fix_biblio_ids portion of get_corrected_marc_record out of rebuild_zebra.pl, and makes it a part of GetMarcBiblio (right before EmbedItemsInMarcBiblio, so the 952s still come last). fix_biblio_ids is kept as a subroutine for the deletion portion of rebuild_zebra.pl, which still uses it. """ But it does not explain why it's better to have it in GetMarcBiblio. If we need it for the reindexation process, we shouldn't impact GetMarcBiblio which is used from several different places. We might then consider adding the fix_biblio_ids call to rebuild_zebra.pl, but I am failing to understand in which cases it could be useful. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.