https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42667 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Pedro Amorim (ammopt) from comment #37)
Hi guys, a few gaps here worth addressing:
Issue 1: Reports table row still shows "Edit" to unauthorized users 1) Create two staff patrons with only create_reports (not edit_all_reports), e.g. Alice and Bob. 2) Log in as Alice, go to Reports → Create from SQL, add a name and 'select 1' as the query. Save it. 3) Log in as Bob: http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl 4) Find Alice's report in the list, open its row actions dropdown. => Expected: no "Edit" option (Bob doesn't own it, no edit_all_reports). Actual: "Edit" is shown, clicking it lands on "insufficient permission", proving it should never have been shown.
Issue 2: Preview modal's edit button missing even for the report's owner (confirmed regression) 1) Log in as any staff patron with create_reports. 2) Go to Reports → Create from SQL, add a name and select 1 as the query. Save it. 3) Go to the reports list: http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl 4) On your own report's row, click "Preview SQL". 5) Look inside the preview modal for an "Edit" option. => Expected: since you own the report, Edit should be there (and did show, for anyone with create_reports, before this patchset). Actual: it's missing, for every user, including superlibrarian.
Thanks Pedro, I've addressed each issue with a follow-up. Setting back to PQA. -- You are receiving this mail because: You are watching all bug changes.