https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37020 --- Comment #39 from David Gustafsson <glasklas@gmail.com> --- Sounds good, though I don't understand the need to use XML::LibXML::Reader instead of MARC::File::XML. MARC::File::XML does perhaps have some odd behaviour when it comes to encoding, but there already is a worked around for this and it's just much nicer and more readable to have the MARC::Batch interface for all formats, and no special handling for MARC XML. There is also a slight risk of introducing new bugs by rewriting code that already has been tried and tested, to me it's better to leave it as it is. Anyway, I think what we should do is: * review your patch * merge it if it works * start another bugzilla issue to refactor bulkmarcimport to use XML::LibXML::Reader for streaming XML input files -- You are receiving this mail because: You are watching all bug changes.