https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43137 --- Comment #18 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to David Nind from comment #13)
Adding my testing notes from when there were four patch, and things were visible.
That was some `git bz` error from me. Solved!
Still looks some work going on or approach changed.
This is ready for review and I plan to act quickly on feedback
Happy to sign off when things are ready (and related bugs).
Really like this!
For me, with Zebra stopped, it took a while for it change to red - it was still showing as green for some time, even though under the server information tab it said "Zebra server seems not to be available. Is it started?".
That's expected, because status is cached for 30 seconds and polling happens every 60. This can be discussed but it was the best I could come up with. On busy systems caching will be critical.
Feedback on message icons: - OK: Green + black circle with a tick - I think the maybe the icons used for warnings vs errors should be changed: - Warning alert: I think this should have the i in an orange circle (yellow background for alert box) - Error alert: I think this should have the ! in a red triangle (red background colour for alert box)
Thanks! Will look tomorrow.
Testing notes (using KTD with es9): 1. I didn't use git worktrees, just a single KTD instance. 2. By default, with es9, the status shows as orange with this warning (has a red triangle red with ! icon, yellow background) (assuming with bug 43127 that this will disappear): Search engine (Elasticsearch) - Cluster status is yellow: 10 unassigned shards 3. Step 6: Elasticsearch failure (has a circle with ! icon, pink/red background): Search engine (Elasticsearch) - Elasticsearch ping failed 4. Step 7: Zebra search engine - working (tick in black circle, green background): Search engine (Zebra) - Operational 5. Step 8: Zebra search engine failure (black circle with i icon, light red background): - It took a while to show as red (the Elasticsearch one showed very quickly) even though the status under server information tab showed: Zebra status: Zebra server seems not to be available. Is it started? - Message showing when Zebra not running: Search engine (Zebra) - Cannot connect to Zebra 6. Tests pass: prove -v t/Koha/Health.t t/Koha/Health/SearchEngine.t
-- You are receiving this mail because: You are watching all bug changes.