https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48794|0 |1 is obsolete| | --- Comment #11 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 51029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51029&action=edit Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN This is an optional follow up depending on community opinion. While copying over the code form the ISBN portion I noticed that with aggressive matching enabled invalid ISBNs (and hence ISSNs) were being stripped from the record. I think in the case of a library exporting records, making changes, and reimporting they would expect to get a match on ISSN or ISBN whether or not the number is valid. This patch changes the subroutine to return the original ISSN in the case of it being invalid. To test: With first patch only export a record with an invalid ISSN and reimport with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match Apply this patch reimport the file and you should find a match. Signed-off-by: Chad Roseburg <croseburg@ncrl.org> -- You are receiving this mail because: You are watching all bug changes.