https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42578 Bug ID: 42578 Summary: Koha/Hold.t failing on date comparison Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 40058 We must use t::lib::Dates::compare to compare dates in test. Koha_Main_D13/218 23:27:19 # Failed test 'Timestamp logged is the current one' 23:27:30 # at t/db_dependent/Koha/Hold.t line 1408. 23:27:35 # '$VAR1 = { 23:27:38 # 'biblionumber' => 3801, 23:34:33 # 'borrowernumber' => 3002, 23:34:36 # 'branchcode' => 'lxMFj7PU', 23:34:39 # 'cancellation_reason' => undef, 23:34:41 # 'cancellationdate' => undef, 23:34:45 # 'deleted_biblionumber' => undef, 23:34:49 # 'desk_id' => undef, 23:34:53 # 'expirationdate' => undef, 23:34:56 # 'found' => undef, 23:34:59 # 'hold_group_id' => undef, 23:35:02 # 'item_group_id' => undef, 23:35:05 # 'item_level_hold' => 1, 23:35:08 # 'itemnumber' => 2658, 23:35:10 # 'itemtype' => undef, 23:35:13 # 'lowestPriority' => 0, 23:35:16 # 'non_priority' => 0, 23:35:32 # 'notificationdate' => undef, 23:35:45 # 'patron_expiration_date' => undef, 23:35:54 # 'priority' => 1, 23:36:01 # 'reminderdate' => undef, 23:36:19 # 'reserve_id' => 357, 23:36:23 # 'reservedate' => '2026-05-08', 23:36:27 # 'reservenotes' => undef, 23:36:30 # 'suspend' => 0, 23:36:33 # 'suspend_until' => undef, 23:36:38 # 'timestamp' => '2026-05-08 23:22:04', 23:36:43 # 'waitingdate' => undef 23:36:53 # }; 23:36:58 # ' 23:36:58 # doesn't match '(?^u:'timestamp' => '2026-05-08 23:22:03')' 23:36:58 # Looks like you failed 1 test of 13. 23:36:58 23:36:58 # Failed test 'item-level holds tests' 23:37:04 # at t/db_dependent/Koha/Hold.t line 1433. 23:37:06 # Looks like you failed 1 test of 6. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40058 [Bug 40058] Move RevertWaitingStatus to Koha::Hold->revert_waiting() -- You are receiving this mail because: You are watching all bug changes.