https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34972 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Emily Lamancusa from comment #34)
As you say, in the second case they should be equal since it's explicitly called after AddReturn. In practice, the first case is always called after AddReturn as well, since we only reach that step after the user has responded to a modal. But that is neither obvious from the code nor strictly enforced, so I used $userenv_branch to be safe (and to be consistent with the immediately preceeding code). Presumably, the item is in the hand of the staff member performing the return, so transferring from the staff member's current location makes sense. I can't think of any situations where we shouldn't make that assumption in returns.pl.
Passing QA -- You are receiving this mail because: You are watching all bug changes.