https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 --- Comment #34 from Agustín Moyano <agustinmoyano@theke.io> --- Hi Jonathan, I'll respond between lines: (In reply to Jonathan Druart from comment #33)
Can you explain what is the purpose of the new table?
This bug adds 2 new tables: club_holds and club_holds_to_patron_holds club_holds has the information of a hold request or error for a certain club.
club_holds_to_patron_holds.error_code seems super odd, it takes the return of CanBookBeReserved and put it in DB??
Think of club_holds_to_patron_holds table more like a log.. it has the information of which holds where generated from a certain club hold, and in case of error, it has the information of the error message, error code and patron. So, if someone, someday wants to create a report on how many holds where made through club holds, they have the info.
How is this table populated? Only from an API endpoint that is not used from Koha?
It's populated in the API endpoint, but it's used in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt line 150 <form action="/api/v1/clubs/[% club.id | html %]/holds" method="post" name="form" id="club-request-form"> -- You are receiving this mail because: You are watching all bug changes.