http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I am quite confuse by this patch. IMO there are some inconsistencies: 1/ I don't understand the usefulness to pass by the template plugin to know if a borrower has overdues or not. 2/ Why did you move parse_letter to the pm file? A subroutine with the same name exists in advance_notices.pl cronjob script (which uses C4::Overdues too, so introduces a redefinion of it)? 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues subroutine in C4::Overdues. 4/ Tests are missing for changes in packages. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.